| Summary: | Web Inspector: Fix missing icons for WI.ThreadTreeElement and selected Heap Snapshots | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Davis <jond> | ||||||||||||||
| Component: | Web Inspector | Assignee: | Jon Davis <jond> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jon Davis
2020-03-06 09:34:55 PST
Created attachment 392733 [details]
Patch
Comment on attachment 392733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392733&action=review r=me > Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:171 > + <g id="ThreadInstrument-light" class="light blue"><use href="#circle"/><use href="#threads"/></g> > + <g id="ThreadInstrument-dark" class="dark blue"><use href="#circle"/><use href="#threads"/></g> I wouldn't really consider this an "instrument". That's a concept specific to timelines. It's not the worst thing for it to use this as well, but it would be nice to have it as it's own icon as it's really a unique concept. Maybe incorporate it into the object type icons with the rounded rect style instead? Created attachment 392776 [details]
Patch
Created attachment 392777 [details]
Selected Heap Snapshot in dark mode
Created attachment 392778 [details]
Selected Heap Snapshot in light mode
Created attachment 392779 [details]
Thread and TypeObject icons in dark mode
Created attachment 392780 [details]
Thread and TypeObject icons in light mode
Comment on attachment 392776 [details]
Patch
r=me, nice!
Comment on attachment 392776 [details] Patch Clearing flags on attachment: 392776 Committed r258039: <https://trac.webkit.org/changeset/258039> All reviewed patches have been landed. Closing bug. |