| Summary: | TextManipulationController should preserve images | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
| Component: | Images | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, koivisto, megan_gardner, mifenton, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ryosuke Niwa
2020-03-05 20:56:36 PST
Created attachment 392669 [details]
WIP
Created attachment 392694 [details]
Patch
Created attachment 392695 [details]
Added more change log descriptions
Comment on attachment 392695 [details] Added more change log descriptions View in context: https://bugs.webkit.org/attachment.cgi?id=392695&action=review > Source/WebCore/ChangeLog:15 > + including ones that do not generate text in Textiterator. This also allows more code sharing between Nit - Textiterator => TextIterator > Source/WebCore/ChangeLog:18 > + For now, we special case nodes with RenderReplace like img element and the root SVG element. Nit - RenderReplace => RenderReplaced (In reply to Wenson Hsieh from comment #5) > Comment on attachment 392695 [details] > Added more change log descriptions > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392695&action=review > > > Source/WebCore/ChangeLog:15 > > + including ones that do not generate text in Textiterator. This also allows more code sharing between > > Nit - Textiterator => TextIterator > > > Source/WebCore/ChangeLog:18 > > + For now, we special case nodes with RenderReplace like img element and the root SVG element. > > Nit - RenderReplace => RenderReplaced Fixed these typos. Committed r258037: <https://trac.webkit.org/changeset/258037> |