Bug 208680
| Summary: | RemoteImageBufferMessageHandler should not manage the lifetime of remote buffers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | Canvas | Assignee: | Dean Jackson <dino> |
| Status: | NEW | ||
| Severity: | Normal | CC: | dino, sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dean Jackson
RemoteImageBufferMessageHandler is supposed to be a message handler. However it actually manages the lifetime of the remote image buffer, by sending a CreateImageBuffer message in its constructor, and a ReleaseImageBuffer in its destructor. I think these operations should be explicit, and called from the actual class that represents the local version of the remote buffer (which is a subclass of RemoteImageBufferMessageHandler, but is really using that as a protocol, not for inheritance).
The create and release operations should be methods on RemoteImageBufferMessageHandler.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/60108973>