| Summary: | Add logging channel for GPU Process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2020-03-05 16:45:37 PST
Created attachment 392650 [details]
Patch
Comment on attachment 392650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392650&action=review > Source/WebCore/platform/Logging.h:65 > + M(GPUProcess) \ I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore? Comment on attachment 392650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392650&action=review >> Source/WebCore/platform/Logging.h:65 >> + M(GPUProcess) \ > > I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore? Yeah, it seems the only use of GPU Process in WebCore is for the internal setting. In my case I wanted to put some logging around where we use RenderingMode::Remote* like things, and ImageBufferBackend. Can you think of a better logging name? (In reply to Dean Jackson from comment #4) > Comment on attachment 392650 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392650&action=review > > >> Source/WebCore/platform/Logging.h:65 > >> + M(GPUProcess) \ > > > > I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore? > > Yeah, it seems the only use of GPU Process in WebCore is for the internal > setting. In my case I wanted to put some logging around where we use > RenderingMode::Remote* like things, and ImageBufferBackend. Can you think of > a better logging name? I see. I think the logging should go into the WebKit layer if at all possible; otherwise, I think it’s probably okay for now, but we should follow up with a patch that moves remote image buffer/GPU process logging out of WebCore and into WebKit (by way of ChromeClient, etc.) |