Bug 208657

Summary: [JSC] Undefined behavior due to missing return statements
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 mark.lam: review-

David Kilzer (:ddkilzer)
Reported 2020-03-05 10:50:20 PST
Undefined behavior in JavaScriptCore due to missing return statements. <rdar://problem/60090482>
Attachments
Patch v1 (11.68 KB, patch)
2020-03-05 10:54 PST, David Kilzer (:ddkilzer) 		mark.lam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-03-05 10:54:26 PST
Created attachment 392599 [details] Patch v1
Mark Lam
Comment 2 2020-03-05 10:58:58 PST
Comment on attachment 392599 [details] Patch v1 r=me
Yusuke Suzuki
Comment 3 2020-03-05 13:07:08 PST
I think this is intentional. We would like to make B3/Air's generated code for the super frequently used functions as much as possible. And we intentionally avoid using RELEASE_ASSERT_NOT_REACHED(), and instead, using IGNORE_RETURN_TYPE_WARNINGS_BEGIN to suppress this type of warnings. So I don't think we should use RELEASE_ASSERT_NOT_REACHED().
Mark Lam
Comment 4 2020-03-05 13:12:45 PST
Comment on attachment 392599 [details] Patch v1 Removing r+ given Yusuke's comment.
David Kilzer (:ddkilzer)
Comment 5 2020-03-05 14:27:10 PST
(In reply to Yusuke Suzuki from comment #3) > I think this is intentional. We would like to make B3/Air's generated code > for the super frequently used functions as much as possible. And we > intentionally avoid using RELEASE_ASSERT_NOT_REACHED(), and instead, using > IGNORE_RETURN_TYPE_WARNINGS_BEGIN to suppress this type of warnings. So I > don't think we should use RELEASE_ASSERT_NOT_REACHED(). Okay, moving NTBF. Looks like IGNORE_RETURN_TYPE_WARNINGS_BEGIN macros are already in these files. This issue was found by a different tool.
Note You need to log in before you can comment on or make changes to this bug.