Bug 208653

Summary: REGRESSION (r257862): imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual.svg is failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: SVGAssignee: Ben Nham <nham>
Status: NEW ---    
Severity: Normal CC: nham, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jacob Uphoff 2020-03-05 10:08:38 PST
imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual.svg

This test started to fail on iOS after commit r257862 

You can reproduce this just by running the test on iOS.

History:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fimport%2Fstruct-dom-06-b-manual.svg

Diff:

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual-actual.txt
@@ -4,7 +4,7 @@
   RenderSVGRoot {svg} at (0,0) size 800x600
     RenderSVGHiddenContainer {defs} at (0,0) size 0x0
     RenderSVGContainer {g} at (83,304) size 299x37
-      RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF0000]}] [x=0.00] [y=0.00] [width=0.00] [height=0.00]
+      RenderSVGRect {rect} at (0,0) size 750x600 [fill={[type=SOLID] [color=#FF0000]}] [x=0.00] [y=0.00] [width=0.00] [height=0.00]
       RenderSVGText {text} at (50,182) size 180x23 contains 1 chunk(s)
         RenderSVGInlineText {#text} at (0,0) size 180x22
           chunk 1 text run 1 at (50.00,200.00) startOffset 0 endOffset 20 width 179.07: "DOM API is supported"
Comment 1 Radar WebKit Bug Importer 2020-03-05 10:09:03 PST
<rdar://problem/60088608>
Comment 2 zalan 2020-03-05 10:17:11 PST
This looks like a progression to me. Will check and rebaseline.
Comment 3 Ben Nham 2020-03-05 10:26:38 PST
This test has been flaky on Mac with the exact same diff in the past, and we marked it as such:

https://bugs.webkit.org/show_bug.cgi?id=204312
Comment 4 Ben Nham 2020-03-05 13:04:29 PST
After talking to Alan and Jacob, the plan is to mark this as flaky on iOS as well, and change the expectations file to reference the older bug (https://bugs.webkit.org/show_bug.cgi?id=204312) to investigate why the SVG render tree output has 0w/0h but non-zero size output in certain cases.
Comment 5 Ben Nham 2020-03-05 13:10:02 PST
Created attachment 392612 [details]
Patch