| Summary: | webkitpy: Be explicit about SCM binary locations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, glenn, jlewis3 | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-03-05 07:53:06 PST
Created attachment 392568 [details]
Patch
What prompted this change, when this code has been working for years? Comment on attachment 392568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392568&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:59 > + executable_name = '/usr/bin/git' is this location same on all the OSes? > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:79 > + executable_name = '/usr/local/bin/svn' Ditto. Comment on attachment 392568 [details]
Patch
bot612:~ buildbot$ which svn
/usr/bin/svn
I think that the git stub is always in /usr/bin currently, but I don't know if that will never change.
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 392568 [details] > Patch > > bot612:~ buildbot$ which svn > /usr/bin/svn > > I think that the git stub is always in /usr/bin currently, but I don't know > if that will never change. Looks like I have an svn in /usr/bin/svn too, even though which svn points to a different one. Created attachment 392649 [details]
Patch
Comment on attachment 392649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392649&action=review > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:79 > + executable_name = '/usr/bin/svn' Pretty sure that /usr/bin/svn isn't guaranteed to exist either. Also, this code isn't about macOS only, or is it? |