| Summary: | Add logging support for capture sources in GPUProcess | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-03-05 05:46:36 PST
Created attachment 392559 [details]
Patch
Created attachment 392560 [details]
Patch
Created attachment 392561 [details]
Patch
Comment on attachment 392561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392561&action=review > Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:160 > + source->setLogger(logger(), source.ptr()); We're not supposed use pointers for log identifiers. You could use childLogIdentifier(...) like we do for AudioContext and MediaSourcePrivateAVFObjC. > Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:209 > + source->setLogger(m_connectionProxy->logger(), source.ptr()); Ditto. Created attachment 392573 [details]
Patch
Comment on attachment 392573 [details] Patch Clearing flags on attachment: 392573 Committed r257919: <https://trac.webkit.org/changeset/257919> All reviewed patches have been landed. Closing bug. |