| Summary: | [iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-03-05 04:55:21 PST
Created attachment 392557 [details]
Patch
Comment on attachment 392557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392557&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513 > + // In case of cloning, we might have more than a single source and we do not want one to interrupt the other. What happens if capture is active in the web process? > LayoutTests/platform/ios/TestExpectations:112 > +fast/mediastream/MediaStreamTrack-clone.html [ Pass ] > +fast/mediastream/MediaStream-clone.html [ Pass ] > +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ] Nice! (In reply to Eric Carlson from comment #2) > Comment on attachment 392557 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392557&action=review > > > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513 > > + // In case of cloning, we might have more than a single source and we do not want one to interrupt the other. > > What happens if capture is active in the web process? A different factory will be used so we would not hit this code path. > > LayoutTests/platform/ios/TestExpectations:112 > > +fast/mediastream/MediaStreamTrack-clone.html [ Pass ] > > +fast/mediastream/MediaStream-clone.html [ Pass ] > > +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ] > > Nice! Created attachment 393137 [details]
Patch for landing
Comment on attachment 393137 [details] Patch for landing Clearing flags on attachment: 393137 Committed r258202: <https://trac.webkit.org/changeset/258202> All reviewed patches have been landed. Closing bug. |