| Summary: | Make m_viewportConstrainedObjects into a WeakHashSet | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, koivisto, kondapallykalyan, luiz, pdr, rniwa, simon.fraser, tonikitoo, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2020-03-04 22:00:16 PST
Created attachment 392535 [details]
Patch
Comment on attachment 392535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392535&action=review > Source/WebCore/page/FrameView.h:301 > - bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; } > + bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->computeSize(); } Use !m_viewportConstrainedObjects->computeEmpty() instead. computeSize() will iterate over the entire map. Created attachment 392580 [details]
Patch
Comment on attachment 392580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392580&action=review > Source/WebCore/page/FrameView.h:299 > + typedef WeakHashSet<RenderLayerModelObject> ViewportConstrainedObjectSet; using ViewportConstrainedObjectSet = WeakHashSet<RenderLayerModelObject>; reads better though I'm not sure this is needed in the first place. Created attachment 392583 [details]
Patch
Comment on attachment 392583 [details] Patch Clearing flags on attachment: 392583 Committed r257933: <https://trac.webkit.org/changeset/257933> |