Bug 208623

Summary: Make m_slowRepaintObjects a WeakHashSet
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2020-03-04 21:42:12 PST 
Make m_slowRepaintObjects a WeakHashSet
Comment 1 Simon Fraser (smfr) 2020-03-04 21:43:11 PST 
Created attachment 392534 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-04 22:38:28 PST 
Comment on attachment 392534 [details]
Patch

Clearing flags on attachment: 392534

Committed r257902: <https://trac.webkit.org/changeset/257902>
Comment 3 WebKit Commit Bot 2020-03-04 22:38:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-04 22:39:14 PST 
<rdar://problem/60072474>
Comment 5 Antti Koivisto 2020-03-04 23:18:27 PST 
Comment on attachment 392534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392534&action=review

> Source/WebCore/page/FrameView.h:826
>      std::unique_ptr<ListHashSet<RenderEmbeddedObject*>> m_embeddedObjectsToUpdate;

We need WeakListHashSet too.