| Summary: | [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-03-04 14:36:29 PST
Created attachment 392487 [details]
Patch
Comment on attachment 392487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392487&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925 > + if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) { The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but rendering with the fallback font, right? There's CSS to control this. Also I guess we don't care about style.visibility() == Hidden on an ancestor? (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 392487 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392487&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925 > > + if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) { > > The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but > rendering with the fallback font, right? There's CSS to control this. > > Also I guess we don't care about style.visibility() == Hidden on an ancestor? Yeah. This is very basic. Created attachment 392503 [details]
Patch
Comment on attachment 392503 [details] Patch Clearing flags on attachment: 392503 Committed r257899: <https://trac.webkit.org/changeset/257899> All reviewed patches have been landed. Closing bug. |