Bug 208598

Summary: REGRESSION: (r257840?) [ Mac wk2 Debug ] fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html is crashing.
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: New BugsAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.15   
Attachments:
Description Flags
replaced-intrinsic-width-simple-crash-log
none
Patch
none
Patch
none
Patch none

Description Jason Lawrence 2020-03-04 13:44:18 PST 
Created attachment 392472 [details]
replaced-intrinsic-width-simple-crash-log

fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html

Description:
This test is crashing on wk2 Debug. This appears to be a regression associated with r257840.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Flayoutformattingcontext%2Fblock-only%2Freplaced-intrinsic-width-simple.html&style=debug&flavor=gpuprocess&flavor=wk2&platform=mac&limit=50000

Crash log;
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x00000002293a2e0e WTFCrash + 14 (Assertions.cpp:305)
1   com.apple.WebCore             	0x000000020c934deb WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x000000020fc1a503 WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree(WebCore::Layout::LayoutState const&, WebCore::RenderView const&) + 275
3   com.apple.WebCore             	0x000000020ff9025d WebCore::FrameViewLayoutContext::layoutUsingFormattingContext() + 861 (FrameViewLayoutContext.cpp:96)
4   com.apple.WebCore             	0x000000020ff91477 WebCore::FrameViewLayoutContext::layout() + 2135 (FrameViewLayoutContext.cpp:254)
5   com.apple.WebCore             	0x000000020f17d3df WebCore::Document::implicitClose() + 1023 (Document.cpp:3064)
6   com.apple.WebCore             	0x000000020fd2a2eb WebCore::FrameLoader::checkCallImplicitClose() + 155 (FrameLoader.cpp:965)
7   com.apple.WebCore             	0x000000020fd29dca WebCore::FrameLoader::checkCompleted() + 442 (FrameLoader.cpp:905)
8   com.apple.WebCore             	0x000000020fd29e4d WebCore::FrameLoader::loadDone(WebCore::LoadCompletionType) + 45 (FrameLoader.cpp:828)
9   com.apple.WebCore             	0x000000020fe4f0b1 WebCore::CachedResourceLoader::loadDone(WebCore::LoadCompletionType, bool) + 225 (CachedResourceLoader.cpp:1348)
10  com.apple.WebCore             	0x000000020fdc615d WebCore::SubresourceLoader::notifyDone(WebCore::LoadCompletionType) + 125 (SubresourceLoader.cpp:830)
11  com.apple.WebCore             	0x000000020fdc2a1c WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) + 2508 (SubresourceLoader.cpp:730)
12  com.apple.WebKit              	0x0000000201475f17 WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) + 775
13  com.apple.WebKit              	0x0000000201abb31a void IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, 0ul>(WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>&&, std::__1::integer_sequence<unsigned long, 0ul>) + 154 (HandleMessage.h:42)
14  com.apple.WebKit              	0x0000000201abb250 void IPC::callMemberFunction<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebCore::NetworkLoadMetrics>&&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) + 112 (HandleMessage.h:48)
15  com.apple.WebKit              	0x0000000201ab886b void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) + 283 (HandleMessage.h:115)
16  com.apple.WebKit              	0x0000000201ab7d8a WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) + 826 (WebResourceLoaderMessageReceiver.cpp:70)
17  com.apple.WebKit              	0x0000000201468ca6 WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 166 (NetworkProcessConnection.cpp:90)
18  com.apple.WebKit              	0x0000000200072c79 IPC::Connection::dispatchMessage(IPC::Decoder&) + 473 (Connection.cpp:1009)
19  com.apple.WebKit              	0x00000002000735e1 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 577
20  com.apple.WebKit              	0x0000000200073ca3 IPC::Connection::dispatchOneIncomingMessage() + 211 (Connection.cpp:1146)
21  com.apple.WebKit              	0x0000000200092c8b IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7::operator()() + 91 (Connection.cpp:986)
22  com.apple.WebKit              	0x0000000200092ba9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7, void>::call() + 25 (Function.h:52)
23  com.apple.JavaScriptCore      	0x00000002293cd23a WTF::Function<void ()>::operator()() const + 138 (Function.h:84)
24  com.apple.JavaScriptCore      	0x0000000229443cf8 WTF::RunLoop::performWork() + 280 (RunLoop.cpp:120)
25  com.apple.JavaScriptCore      	0x00000002294453ae WTF::RunLoop::performWork(void*) + 30 (RunLoopCF.cpp:39)
26  com.apple.CoreFoundation      	0x00007fff30f17b21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
27  com.apple.CoreFoundation      	0x00007fff30f17ac0 __CFRunLoopDoSource0 + 103
28  com.apple.CoreFoundation      	0x00007fff30f178d4 __CFRunLoopDoSources0 + 209
29  com.apple.CoreFoundation      	0x00007fff30f16740 __CFRunLoopRun + 1272
30  com.apple.CoreFoundation      	0x00007fff30f15bd3 CFRunLoopRunSpecific + 499
31  com.apple.Foundation          	0x00007fff335b91a8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
32  com.apple.Foundation          	0x00007fff3366cd8b -[NSRunLoop(NSRunLoop) run] + 76
33  libxpc.dylib                  	0x00007fff6880a0e1 _xpc_objc_main.cold.4 + 49
34  libxpc.dylib                  	0x00007fff6880a027 _xpc_objc_main + 559
35  libxpc.dylib                  	0x00007fff68809b5a xpc_main + 377
36  com.apple.WebKit              	0x000000020084340e WebKit::XPCServiceMain(int, char const**) + 1278 (XPCServiceMain.mm:164)
37  com.apple.WebKit              	0x0000000201b6c58b WKXPCServiceMain + 27 (WKMain.mm:33)
38  com.apple.WebKit.WebContent   	0x00000001031ccec2 main + 34 (AuxiliaryProcessMain.cpp:30)
39  libdyld.dylib                 	0x00007fff685bb7fd start + 1
Comment 1 Radar WebKit Bug Importer 2020-03-04 13:45:08 PST 
<rdar://problem/60054452>
Comment 2 zalan 2020-03-04 13:56:23 PST 
Created attachment 392473 [details]
Patch
Comment 3 zalan 2020-03-04 13:58:22 PST 
Created attachment 392474 [details]
Patch
Comment 4 Jason Lawrence 2020-03-04 14:00:48 PST 
I have marked this test as crashing here: https://trac.webkit.org/changeset/257878/webkit
Comment 5 zalan 2020-03-04 14:10:31 PST 
Created attachment 392480 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-04 15:09:13 PST 
The commit-queue encountered the following flaky tests while processing attachment 392480 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-03-04 15:09:47 PST 
Comment on attachment 392480 [details]
Patch

Clearing flags on attachment: 392480

Committed r257880: <https://trac.webkit.org/changeset/257880>
Comment 8 WebKit Commit Bot 2020-03-04 15:09:48 PST 
All reviewed patches have been landed.  Closing bug.