Bug 208594

Summary: Adopt new and improved CFNetwork SPI for cookie change notifications
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ggaren, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-03-04 13:19:25 PST 
Adopt new and improved CFNetwork SPI for cookie change notifications.
Comment 1 Radar WebKit Bug Importer 2020-03-04 13:19:42 PST 
<rdar://problem/60053313>
Comment 2 Chris Dumez 2020-03-04 13:27:32 PST 
Created attachment 392469 [details]
Patch
Comment 3 Chris Dumez 2020-03-04 14:26:02 PST 
Created attachment 392484 [details]
Patch
Comment 4 Chris Dumez 2020-03-04 14:28:15 PST 
Comment on attachment 392484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392484&action=review

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:595
> +            if (cookies.isEmpty())

The only change in this latest iteration was early returning here if the list of cookies is empty after filtering out the httpOnly ones. No need to do unnecessary IPC in this case.
Comment 5 WebKit Commit Bot 2020-03-04 15:28:18 PST 
Comment on attachment 392484 [details]
Patch

Clearing flags on attachment: 392484

Committed r257888: <https://trac.webkit.org/changeset/257888>
Comment 6 WebKit Commit Bot 2020-03-04 15:28:20 PST 
All reviewed patches have been landed.  Closing bug.