Bug 208579

Summary: Remove PlatformPath, PlatformPathPtr, and PlatformPathStorageType typedefs in Path.h
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Wenson Hsieh 2020-03-04 10:02:06 PST
These are essentially unused, don’t provide much tangible benefit since there’s no platform agnostic code that reasons with any of these “abstract” types.
Comment 1 Wenson Hsieh 2020-03-04 10:11:46 PST
From https://bugs.webkit.org/show_bug.cgi?id=208492:

Darin Adler 2020-03-04 10:07:09 PST
(In reply to Wenson Hsieh from comment #12)
> Would you suggest we rename platformPath, ensurePlatformPath, and m_path to
> something along the lines of nativePath, ensureNativePath, and m_nativePath
> (respectively)?


For CG, I would suggesting calling them something like this:

pathCG or immutableCGPath or cgPath
mutableCGPath
m_path or m_pathCG or m_cgPath

No abstract name for "what CG is", because the code that uses this will all be CG-specific.
Comment 2 Darin Adler 2020-03-04 19:54:34 PST
Other possible naming would be m_underlyingPath