Bug 208577

Summary:

REGRESSION (r257840?) [ Mac wk2 Release ] fast/hidpi/image-srcset-relative-svg-canvas.html is flaky failing.

Product:

WebKit

Reporter:

Jason Lawrence <Lawrence.j>

Component:

SVG

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

macOS 10.14

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224121

Attachments:

Description	Flags
image-srcset-relative-svg-canvas-diff	none
Patch	none
Patch	none

Description Jason Lawrence 2020-03-04 09:32:51 PST

Created attachment 392425 [details]
image-srcset-relative-svg-canvas-diff

fast/hidpi/image-srcset-relative-svg-canvas.html

Description:
This test is flaky failing on Mac wk2 Release recently. There are some older failures, but a lot of passes between them. The older diff has a different percentage and image, changed from .1% to .12%.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fhidpi%2Fimage-srcset-relative-svg-canvas.html

Diff:
https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r257840%20(3446)/fast/hidpi/image-srcset-relative-svg-canvas-diff.png

Comment 1 Radar WebKit Bug Importer 2020-03-04 09:45:29 PST

<rdar://problem/60043401>

Comment 2 Jason Lawrence 2020-03-04 09:47:49 PST

I can reproduce this issue on r257841 using the command below.
--iterations 2000 --exit-after-n-failures 5 --force -f fast/hidpi/image-srcset-relative-svg-canvas.html --no-retry

[1/2000][4/2000] fast/hidpi/image-srcset-relative-svg-canvas.html failed unexpectedly (reference mismatch)
[17/2000] fast/hidpi/image-srcset-relative-svg-canvas.html failed unexpectedly (reference mismatch)
[18/2000] fast/hidpi/image-srcset-relative-svg-canvas.html failed unexpectedly (reference mismatch)
[19/2000] fast/hidpi/image-srcset-relative-svg-canvas.html failed unexpectedly (reference mismatch)
[25/2000] fast/hidpi/image-srcset-relative-svg-canvas.html failed unexpectedly (reference mismatch)
Exiting early after 5 failures. 22 tests run.
17 tests ran as expected, 5 didn't (1978 didn't run):



Same command on r257839 gives this result:
All 2000 tests ran as expected.

Comment 3 zalan 2020-03-04 10:59:43 PST

Created attachment 392442 [details]
Patch

Comment 4 zalan 2020-03-04 11:25:19 PST

Created attachment 392444 [details]
Patch

Comment 5 zalan 2020-03-04 11:26:09 PST

I was able to reproduce this failure.

Comment 6 WebKit Commit Bot 2020-03-05 15:13:51 PST

Comment on attachment 392444 [details]
Patch

Clearing flags on attachment: 392444

Committed r257951: <https://trac.webkit.org/changeset/257951>

Comment 7 WebKit Commit Bot 2020-03-05 15:13:53 PST

All reviewed patches have been landed.  Closing bug.