| Summary: | Export NowPlaying commands to GPUProcess when media playing in GPUProcess is enabled | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | annulen, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
youenn fablet
2020-03-04 01:51:19 PST
Created attachment 392395 [details]
Patch
Created attachment 392396 [details]
Patch
Created attachment 392402 [details]
Patch
Created attachment 392404 [details]
Patch
Created attachment 392407 [details]
Patch
Created attachment 392409 [details]
Patch
Crashes should go away with https://bugs.webkit.org/show_bug.cgi?id=208578 Comment on attachment 392409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392409&action=review r=me once the bots are happy > Source/WebCore/html/MediaElementSession.cpp:993 > + double currentTime = std::isfinite(m_element.currentTime()) && m_element.supportsSeeking() ? m_element.currentTime() : MediaPlayer::invalidTime(); Nit: m_element.currentTime() can be fairly expensive, so it would be good to cache it in a local instead of calling twice. > Source/WebCore/html/MediaElementSession.cpp:995 > + return NowPlayingInfo { m_element.mediaSessionTitle(), m_element.sourceApplicationIdentifier(), duration, currentTime, m_element.supportsSeeking(), m_element.mediaSessionUniqueIdentifier(), isPlaying, allowsNowPlayingControlsVisibility }; May as well also have a local for m_element.supportsSeeking() since it is used three times. > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:242 > + double rate = nowPlayingInfo.isPlaying ? 1 : 0; Nit: two spaces after '=' > Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:276 > + // FIXME: Fix this layering violation. !! Created attachment 392551 [details]
Patch
Created attachment 392554 [details]
Patch for landing
Moved the bits from bug 208578 here instead. Comment on attachment 392554 [details] Patch for landing Clearing flags on attachment: 392554 Committed r257913: <https://trac.webkit.org/changeset/257913> All reviewed patches have been landed. Closing bug. |