| Summary: | Implement WKTextSelectionRect in terms of WebCore::SelectionRect and WKTextRange in terms of WKTextSelectionRect | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||
| Hardware: | iPhone / iPad | ||||||||||||||||||||
| OS: | iOS 13 | ||||||||||||||||||||
| Bug Depends on: | 208561 | ||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Daniel Bates
2020-03-03 23:57:12 PST
Created attachment 392380 [details]
For the bots
Created attachment 392381 [details]
For the bots
Created attachment 392382 [details]
For the bots
Created attachment 392383 [details] Patch This patch will fail to apply without the patch for bug #208561. Created attachment 392386 [details]
For the bots
Created attachment 392390 [details]
Patch
Created attachment 392391 [details]
Patch
Created attachment 392392 [details]
For the bots
Comment on attachment 392391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392391&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4465 > + auto rects = adoptNS([[NSMutableArray alloc] initWithCapacity:coreRects.size()]); arrayWithCapacity? (In reply to Alex Christensen from comment #9) > Comment on attachment 392391 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392391&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4465 > > + auto rects = adoptNS([[NSMutableArray alloc] initWithCapacity:coreRects.size()]); > > arrayWithCapacity? I thought about it when I wrote this code and was debating whether to RetainPtr it all up or not. At the end fo the day I chose to go with RetainPtr (even though the code is not long!). The generated code will be just as efficient because of the inlining of autorelease() Thanks for the review. Comment on attachment 392391 [details] Patch Clearing flags on attachment: 392391 Committed r257852: <https://trac.webkit.org/changeset/257852> All reviewed patches have been landed. Closing bug. |