| Summary: | Move WKTextSelectionRect into its own file | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | iOS 13 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 208563 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Daniel Bates
2020-03-03 22:58:29 PST
Created attachment 392375 [details]
Patch
Created attachment 392376 [details]
Patch
Created attachment 392378 [details]
Patch
Comment on attachment 392378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392378&action=review > Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32 > +#import <WebKit/WebSelectionRect.h> Do we still need this in WKContentViewInteraction.mm? (In reply to Alex Christensen from comment #4) > Comment on attachment 392378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392378&action=review > > > Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32 > > +#import <WebKit/WebSelectionRect.h> > > Do we still need this in WKContentViewInteraction.mm? Yes for webSelectionRectsForSelectionRects(), but I sooo wanted to remove it. I was very tempted to move webSelectionRectsForSelectionRects() out of it to do so, but I decided to do a smaller step just to make it easy to a review. Thanks for the review. Comment on attachment 392378 [details] Patch Clearing flags on attachment: 392378 Committed r257851: <https://trac.webkit.org/changeset/257851> All reviewed patches have been landed. Closing bug. |