| Summary: | [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2020-03-03 21:34:31 PST
Created attachment 392408 [details]
Patch
Comment on attachment 392408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392408&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > - m_textContent->expand(-1); wut > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > + constexpr size_t trailingTrimmableContentLength = 1; > + m_textContent->shrink(trailingTrimmableContentLength); I have concerns. (In reply to Antti Koivisto from comment #3) > Comment on attachment 392408 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392408&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > > - m_textContent->expand(-1); > > wut > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > > + constexpr size_t trailingTrimmableContentLength = 1; > > + m_textContent->shrink(trailingTrimmableContentLength); > > I have concerns. Me too! Comment on attachment 392408 [details] Patch Clearing flags on attachment: 392408 Committed r257841: <https://trac.webkit.org/changeset/257841> All reviewed patches have been landed. Closing bug. |