Bug 208554

Summary:

Add SPI _WKResourceLoadInfo.loadedFromCache

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Alex Christensen 2020-03-03 19:22:14 PST

Add SPI _WKResourceLoadInfo.loadedFromCache

Comment 1 Alex Christensen 2020-03-03 19:40:01 PST

Created attachment 392363 [details]
Patch

Comment 2 Wenson Hsieh 2020-03-03 21:58:42 PST

Comment on attachment 392363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392363&action=review

> Source/WebKit/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Nit - it’s admittedly pretty self-explanatory, but it would be nice to have a sentence or two explaining what this new SPI does.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:328
> +    EXPECT_EQ(archiveData.length, 589ull);

Ideally we'd have a test that checks the value of -loadedFromCache, but maybe it can be done as a followup.

Comment 3 Alex Christensen 2020-03-03 22:11:56 PST

http://trac.webkit.org/r257834

Comment 4 Radar WebKit Bug Importer 2020-03-03 22:12:16 PST

<rdar://problem/60027433>