| Summary: | Drop WebsiteDataStore::processPools()'s ensureAPoolExists optional parameter and add a ensureProcessPools() method instead | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, beidson, ggaren, katherine_cheney, sam, simon.fraser, webkit-bug-importer, wilander | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208610 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 208541 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2020-03-03 16:35:03 PST
Created attachment 392348 [details]
Patch
Comment on attachment 392348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392348&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:304 > + enum class EnsureHasProcessPool : bool { No, Yes }; > + HashSet<RefPtr<WebProcessPool>> processPools(EnsureHasProcessPool, size_t limit = std::numeric_limits<size_t>::max()) const; The idiom we often use for things like this is to have two functions: 1) ensureProcessPools() 2) existingProcessPools() or possibly just processPools(). Created attachment 392434 [details]
Patch
Created attachment 392436 [details]
Patch
Comment on attachment 392436 [details] Patch Clearing flags on attachment: 392436 Committed r257855: <https://trac.webkit.org/changeset/257855> All reviewed patches have been landed. Closing bug. |