| Summary: | commit-queue should run WK2 tests instead of WK1 tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208716 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-03-03 16:01:05 PST
Created attachment 392346 [details]
Patch
I'd like Alexey to confirm the original rationale, which I suspect was that WebKit1 tests were more stable and better gardened. (In reply to Jonathan Bedard from comment #2) > I'd like Alexey to confirm the original rationale, which I suspect was that > WebKit1 tests were more stable and better gardened. Didn't read through all my email: "IIRC they were gardened equally well, but we knew that WebKit2 ran fewer tests because of unimplemented WebKitTestRunner functionality. That's still true as far as functionality goes, but there are now many WebKit2 only features and more code in WebKit2 itself. So I also think that we should switch CQ to WebKit2." Please do send a heads up to webkit-dev. Committed r257927: <https://trac.webkit.org/changeset/257927> All reviewed patches have been landed. Closing bug and clearing flags on attachment 392346 [details]. |