| Summary: | [ews] Add build step to create local git commit for commit-queue | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208589 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2020-03-03 14:44:06 PST
Created attachment 392337 [details]
Patch
Comment on attachment 392337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392337&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2474 > + commit_message_filename = '/tmp/{}.txt'.format(self.getProperty('patch_id')) Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pip the commit message over stdin? Seems cleaner than sending it into a file. Created attachment 392415 [details]
Patch
(In reply to Jonathan Bedard from comment #3) > Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pipe the commit message over stdin? Done in updated patch. Comment on attachment 392415 [details]
Patch
Much cleaner all in the same step!
Committed r257848: <https://trac.webkit.org/changeset/257848> |