| Summary: | Rename urlSelected to changeLocation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, dbarton, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, gyuyoung.kim, japhet, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Rob Buis
2020-03-03 12:29:55 PST
Created attachment 392310 [details]
Patch
Comment on attachment 392310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392310&action=review > Source/WebCore/loader/FrameLoader.h:-132 > - void changeLocation(FrameLoadRequest&&); Was this just unused? I don’t see any cases of this in the patch. Comment on attachment 392310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392310&action=review >> Source/WebCore/loader/FrameLoader.h:-132 >> - void changeLocation(FrameLoadRequest&&); > > Was this just unused? I don’t see any cases of this in the patch. It was used in a few places but those places can just use one of the old urlSelected overloads (now renamed to changeLocation), since I made the second parameter gain a default value. The old changeLocation was just filling in the second parameter and was not so useful. Darin, I just noticed Source/WebCore/WebCore.order still mentions urlSelected. How important is it to keep this file in sync and is this done regularly? Willing to make a follow up patch if needed. Comment on attachment 392310 [details] Patch Clearing flags on attachment: 392310 Committed r258140: <https://trac.webkit.org/changeset/258140> All reviewed patches have been landed. Closing bug. (In reply to Rob Buis from comment #4) > Darin, I just noticed Source/WebCore/WebCore.order still mentions > urlSelected. How important is it to keep this file in sync and is this done > regularly? Willing to make a follow up patch if needed. Not important at all. I don’t know why those order files are still checked in; there may be a good reason. But no matter what that reason is, they definitely can’t be correctly updated by editing the files by hand. |