Bug 208463

Summary: Annotate editable elements with hit test order
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 13   
Bug Depends on:    
Bug Blocks: 209561    
Attachments:
Description Flags
Patch
none
Patch
none
To land none

Description Daniel Bates 2020-03-02 12:34:39 PST 
Until <rdar://problem/59737118> is fixed, annotate editable elements with their paint order towards fixing <rdar://problem/59602885>.
Comment 1 Radar WebKit Bug Importer 2020-03-02 12:34:51 PST 
<rdar://problem/59962843>
Comment 2 Daniel Bates 2020-03-02 13:01:52 PST 
Created attachment 392176 [details]
Patch
Comment 3 Daniel Bates 2020-03-02 13:25:11 PST 
Comment on attachment 392176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392176&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContextInternal.h:39
> +- (NSUInteger)_paintOrder;

Should be @property
Comment 4 Daniel Bates 2020-03-02 13:26:20 PST 
Created attachment 392179 [details]
Patch
Comment 5 Wenson Hsieh 2020-03-02 14:21:31 PST 
Comment on attachment 392179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392179&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6834
> +        context.paintOrder = count++;

Nit: IMO, "hitTestingOrder" would be a more relevant name, since this index is directly influenced by the order of elements as they are hit-tested (which, in turn, depends on their painting order).
Comment 6 Daniel Bates 2020-03-02 16:58:21 PST 
Created attachment 392215 [details]
To land
Comment 7 Daniel Bates 2020-03-02 16:59:18 PST 
Committed r257749: <https://trac.webkit.org/changeset/257749>