| Summary: | Web Inspector: Update breakpoint and search type icons | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Davis <jond> | ||||||||||||||
| Component: | Web Inspector | Assignee: | Jon Davis <jond> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jon Davis
2020-03-02 10:04:14 PST
Created attachment 392158 [details]
Patch
Created attachment 392203 [details]
Sources tab in dark mode
Created attachment 392204 [details]
Sources tab in light mode
Created attachment 392205 [details]
Search tab in light mode
Created attachment 392206 [details]
Search tab in dark mode
(In reply to Jon Davis from comment #4) > Created attachment 392205 [details] > Search tab in light mode Off-topic: the window title text is white! Could you please file a bug and include your macOS, Safari, and WebKit version? (In reply to Nikita Vasilyev from comment #6) > (In reply to Jon Davis from comment #4) > > Created attachment 392205 [details] > > Search tab in light mode > > Off-topic: the window title text is white! Could you please file a bug and > include your macOS, Safari, and WebKit version? That seems to be a bug with the Appearance setting in Web Inspector. Comment on attachment 392158 [details]
Patch
r=me
Would it be possible to make the icon used for JavaScript breakpoints use the same icon as the search result (e.g. make only the middle of the three lines white, and have the other two be darker)?
Created attachment 392232 [details]
Patch
Comment on attachment 392232 [details] Patch Clearing flags on attachment: 392232 Committed r257757: <https://trac.webkit.org/changeset/257757> All reviewed patches have been landed. Closing bug. |