Bug 208439

Summary: JSC 32bits broken in debug mode by r257399
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: JavaScriptCoreAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208048    
Attachments:
Description Flags
Patch none

Description Paulo Matos 2020-03-02 03:12:02 PST 
Commit 257399 (bug 207522) breaks 32bit builds in debug mode due to assert calling JSC::JSValueRegs::gpr()

../../Source/JavaScriptCore/bytecode/AccessCase.cpp:1945:41: error: no matching function for call to ‘JSC::JSValueRegs::gpr()’
         ASSERT(baseGPR != valueRegs.gpr());
Comment 1 Paulo Matos 2020-03-02 04:49:38 PST 
Created attachment 392131 [details]
Patch
Comment 2 Caio Lima 2020-03-02 07:15:38 PST 
Comment on attachment 392131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392131&action=review

LGTM

> Source/JavaScriptCore/bytecode/AccessCase.cpp:1947
> +        ASSERT(!valueRegs.uses(scratchGPR));

Nice catch.
Comment 3 Paulo Matos 2020-03-04 02:51:46 PST 
ping!
Comment 4 WebKit Commit Bot 2020-03-04 10:21:54 PST 
Comment on attachment 392131 [details]
Patch

Clearing flags on attachment: 392131

Committed r257856: <https://trac.webkit.org/changeset/257856>
Comment 5 WebKit Commit Bot 2020-03-04 10:21:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-04 10:22:16 PST 
<rdar://problem/60045082>