Bug 208419

Summary: [LFC][MarginCollapsing] Do not re-compute PositiveAndNegativeVerticalMargin values
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: commit-queue+
Patch none

Description zalan 2020-02-29 16:18:53 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-02-29 16:19:10 PST 
<rdar://problem/59923666>
Comment 2 zalan 2020-02-29 16:22:06 PST 
Created attachment 392079 [details]
Patch
Comment 3 Antti Koivisto 2020-02-29 21:58:59 PST 
Comment on attachment 392079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392079&action=review

> Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588
> +    auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox);

hasCollapsedMarginBefore may read better.
Comment 4 zalan 2020-03-01 08:22:58 PST 
Created attachment 392097 [details]
Patch
Comment 5 zalan 2020-03-01 08:23:13 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 392079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392079&action=review
> 
> > Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588
> > +    auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox);
> 
> hasCollapsedMarginBefore may read better.
Indeed!
Comment 6 WebKit Commit Bot 2020-03-01 09:56:02 PST 
Comment on attachment 392097 [details]
Patch

Clearing flags on attachment: 392097

Committed r257690: <https://trac.webkit.org/changeset/257690>
Comment 7 WebKit Commit Bot 2020-03-01 09:56:04 PST 
All reviewed patches have been landed.  Closing bug.