| Summary: | Simplify gradient parsing | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
| Component: | CSS | Assignee: | Darin Adler <darin> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | andersca, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, mifenton, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Darin Adler
2020-02-29 14:15:39 PST
Created attachment 392073 [details]
Patch
Comment on attachment 392073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392073&action=review > Source/WebCore/ChangeLog:8 > + - Use Optional<> and invalid Color to reprsent unspecified positions and colors. Typo "reprsent". Created attachment 392108 [details]
Patch
I’ll land this after EWS confirms I fixed the "use after move" mistake in my earlier patch that was screwing up parsing some gradients. Created attachment 392115 [details]
Patch
Created attachment 392283 [details]
Patch
Created attachment 392533 [details]
Patch
Committed r257966: <https://trac.webkit.org/changeset/257966> |