| Summary: | Add new Mac target numbers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alan Coon <alancoon.bugzilla> | ||||||
| Component: | Tools / Tests | Assignee: | Alan Coon <alancoon> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alancoon, ap, cdumez, commit-queue, dino, eric.carlson, ews-watchlist, graouts, jbedard, jberlin, keith_miller, kondapallykalyan, krollin, mark.lam, msaboff, repstein, rniwa, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alan Coon
2020-02-28 16:19:00 PST
Created attachment 392032 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 392032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392032&action=review > Source/JavaScriptCore/ChangeLog:3 > + Add new Mac target numbers You are only updating xcconfigs in Source. Please update all projects, including those in Tools. Created attachment 392199 [details]
Patch
Comment on attachment 392199 [details]
Patch
With some spot checking, this seems to cover all that we did last year. Did you chek if we had any new projects added since then?
I checked with the following command, so we should be OK. grep -r -l --include \*.xcconfig 'TARGET_MAC_OS_X\|WK_MACOS_1014_YES\|WK_MACOS_BEFORE\|SYSTEM_VERSION_PREFIX_macosx\|MACOS_DEPLOYMENT_TARGET_macosx' . | sort -u Comment on attachment 392199 [details] Patch Clearing flags on attachment: 392199 Committed r257755: <https://trac.webkit.org/changeset/257755> All reviewed patches have been landed. Closing bug. |