| Summary: | Clear FontDatabase when low-memory-warning happens | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2020-02-28 13:16:06 PST
Created attachment 392011 [details]
Patch
Created attachment 392012 [details]
Patch
Comment on attachment 392012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392012&action=review r=me with change. > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1385 > +#if HAVE(DISALLOWABLE_USER_INSTALLED_FONTS) You can replace all this with simply: FontDatabase::singletonAllowingUserInstalledFonts().clear(); FontDatabase::singletonDisallowingUserInstalledFonts().clear(); without ifdefs. FontDatabase::singletonAllowingUserInstalledFonts() & FontDatabase::singletonDisallowingUserInstalledFonts() resolve to FontDatabase::singleton() when !HAVE(DISALLOWABLE_USER_INSTALLED_FONTS) Comment on attachment 392012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392012&action=review >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1385 >> +#if HAVE(DISALLOWABLE_USER_INSTALLED_FONTS) > > You can replace all this with simply: > FontDatabase::singletonAllowingUserInstalledFonts().clear(); > FontDatabase::singletonDisallowingUserInstalledFonts().clear(); > > without ifdefs. FontDatabase::singletonAllowingUserInstalledFonts() & FontDatabase::singletonDisallowingUserInstalledFonts() resolve to FontDatabase::singleton() when !HAVE(DISALLOWABLE_USER_INSTALLED_FONTS) Changed. Committed r257657: <https://trac.webkit.org/changeset/257657> |