Bug 208372

Summary:

Regression r257612: Windows build broken

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, eric.carlson, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=208080

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-02-28 04:53:53 PST

Windows build seems to be broken by r257612.

e.g.: 
build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): error C2220: the following warning is treated as an error [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): warning C4701: potentially uninitialized local variable 'align' used [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): warning C4703: potentially uninitialized local pointer variable 'align' used [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]


r257611 passed in https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/11123
r257612 failed in https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/11124


EWS also indicated this failure in the corresponding bug https://bugs.webkit.org/show_bug.cgi?id=208080

Comment 1 Radar WebKit Bug Importer 2020-02-28 04:55:01 PST

<rdar://problem/59885001>

Comment 2 Eric Carlson 2020-02-28 09:23:20 PST

Created attachment 391984 [details]
Patch

Comment 3 WebKit Commit Bot 2020-02-28 10:14:12 PST

Comment on attachment 391984 [details]
Patch

Clearing flags on attachment: 391984

Committed r257641: <https://trac.webkit.org/changeset/257641>

Comment 4 WebKit Commit Bot 2020-02-28 10:14:14 PST

All reviewed patches have been landed.  Closing bug.