Bug 208359

Summary:

REGRESSION(r257411): Web Inspector: Can't add a breakpoint by pressing the plus button

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2020-02-27 17:27:39 PST

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Sources Tab
3. click on the + to create a breakpoint
=> nothing happens

Regressed in r257411.

Comment 1 Radar WebKit Bug Importer 2020-02-27 17:27:49 PST

<rdar://problem/59870712>

Comment 2 Nikita Vasilyev 2020-02-27 17:48:22 PST

Created attachment 391950 [details]
Patch

Comment 3 BJ Burg 2020-02-27 23:46:29 PST

Comment on attachment 391950 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2020-02-28 00:44:28 PST

The commit-queue encountered the following flaky tests while processing attachment 391950 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.

Comment 5 WebKit Commit Bot 2020-02-28 00:45:04 PST

Comment on attachment 391950 [details]
Patch

Clearing flags on attachment: 391950

Committed r257622: <https://trac.webkit.org/changeset/257622>

Comment 6 WebKit Commit Bot 2020-02-28 00:45:05 PST

All reviewed patches have been landed.  Closing bug.