Bug 208358

Summary: Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dino, koivisto, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208416
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch
none
Patch
none
Patch none

Description Simon Fraser (smfr) 2020-02-27 17:21:48 PST
Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Comment 1 Simon Fraser (smfr) 2020-02-27 17:25:43 PST
Created attachment 391945 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-02-27 22:03:59 PST
Created attachment 391961 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-02-27 23:10:29 PST
Created attachment 391964 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-02-27 23:38:04 PST
Created attachment 391965 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-02-28 08:08:17 PST
Created attachment 391981 [details]
Patch
Comment 6 Simon Fraser (smfr) 2020-02-28 11:24:04 PST
https://trac.webkit.org/changeset/257645/webkit
Comment 7 Radar WebKit Bug Importer 2020-02-28 11:25:36 PST
<rdar://problem/59895819>
Comment 8 Aakash Jain 2020-02-29 09:25:05 PST
(In reply to Simon Fraser (smfr) from comment #6)
> https://trac.webkit.org/changeset/257645/webkit
This seems to have broken Windows build. Tracked in https://bugs.webkit.org/show_bug.cgi?id=208416

EWS also indicated this failure: https://ews-build.webkit.org/#/builders/10/builds/8585