Bug 208346

Summary: [iOS] Remove logging for sysctl access to properties used by NSURLSession
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2020-02-27 15:40:30 PST 
Telemetry and logging indicate that two sysctl calls are needed by [NSURLSession sessionWithConfiguration]. We should allow this access so that it can make appropriate decisions about the network stack for the current device:

kern.ostype
kern.osrelease
Comment 1 Brent Fulgham 2020-02-27 15:40:51 PST 
<rdar://problem/59862967>
Comment 2 Brent Fulgham 2020-02-27 15:45:07 PST 
Created attachment 391936 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-02-27 17:54:23 PST 
Comment on attachment 391936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391936&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:570
> +        "kern.ostype" ;; Needed by NSURLSession

I find these comments to not be very useful in the long term. Certainly such low level functionality is needed - or will be needed - by a lot of frameworks. So not sure what information a future reader will get from the fact that back in 2020, we first noticed it to be used by this particular one.
Comment 4 WebKit Commit Bot 2020-02-27 19:50:19 PST 
Comment on attachment 391936 [details]
Patch

Clearing flags on attachment: 391936

Committed r257615: <https://trac.webkit.org/changeset/257615>
Comment 5 WebKit Commit Bot 2020-02-27 19:50:20 PST 
All reviewed patches have been landed.  Closing bug.