| Summary: | run-javascriptcore-tests: Make upload format valid | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jonathan Bedard
2020-02-27 14:10:52 PST
Created attachment 391915 [details]
Patch
(In reply to Jonathan Bedard from comment #0) > A number of ports are having trouble uploading JSC results. can you provide example? > We should print the json we attempted to upload when the upload fails. Wouldn't json be quite large? How will printing help? Is it for debugging? (In reply to Aakash Jain from comment #2) > (In reply to Jonathan Bedard from comment #0) > > A number of ports are having trouble uploading JSC results. > can you provide example? > > > We should print the json we attempted to upload when the upload fails. > Wouldn't json be quite large? How will printing help? Is it for debugging? Not any larger than the log we've already printed. I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure. (In reply to Jonathan Bedard from comment #3) > I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure. In that case, can you add a FIXME/TODO indicating that this is just for debugging and should be removed in some time. Created attachment 391924 [details]
Patch
Comment on attachment 391924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391924&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: https://bugs.webkit.org/show_bug.cgi?id=208341 It's really hard to understand what this means even after looking at the bug. Can you change this to say something like "This is just for debugging and should be removed once not needed any more"? Even so, it's quite vague and non-actionable. Created attachment 391934 [details]
Patch
Comment on attachment 391934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391934&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: This is for temporary debugging and should be removed https://bugs.webkit.org/show_bug.cgi?id=208341 looks better. Comment on attachment 391934 [details] Patch Clearing flags on attachment: 391934 Committed r257597: <https://trac.webkit.org/changeset/257597> All reviewed patches have been landed. Closing bug. Found our problem: "version":"5.4.0-0" Reopening to attach new patch. Created attachment 391993 [details]
Patch
This will fix the source of the problem: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/17124/steps/jscore-test/logs/stdio https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/12794/steps/jscore-test/logs/stdio Comment on attachment 391993 [details]
Patch
rs=me
Created attachment 391998 [details]
Patch for landing
Comment on attachment 391998 [details] Patch for landing Clearing flags on attachment: 391998 Committed r257647: <https://trac.webkit.org/changeset/257647> All reviewed patches have been landed. Closing bug. |