Bug 208330

Summary: [Win] Fix AppleWin build
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2020-02-27 11:02:36 PST 
CMake is giving an error:

Imported target "WebKit::WTF" includes non-existent path
.../Debug/build32/DerivedSources/ForwardingHeaders/
in its INTERFACE_INCLUDE_DIRECTORIES.
Comment 1 Radar WebKit Bug Importer 2020-02-27 11:07:56 PST 
<rdar://problem/59853955>
Comment 2 Per Arne Vollan 2020-02-27 11:49:26 PST 
Created attachment 391893 [details]
Patch
Comment 3 Don Olmstead 2020-02-27 11:55:58 PST 
Comment on attachment 391893 [details]
Patch

This is wrong. You should be setting this to where the headers actually are.

I'm guessing you should move the setting of these values into the target files. So like

set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF")

Also https://bugs.webkit.org/show_bug.cgi?id=205085 still needs to land
Comment 4 Per Arne Vollan 2020-02-27 13:18:45 PST 
(In reply to Don Olmstead from comment #3)
> Comment on attachment 391893 [details]
> Patch
> 
> This is wrong. You should be setting this to where the headers actually are.
> 
> I'm guessing you should move the setting of these values into the target
> files. So like
> 
> set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF")
> 

It doesn't seem like we used to set this for AppleWin, if I am not mistaken. Is it still needed?

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-02-27 14:36:52 PST 
Created attachment 391919 [details]
Patch
Comment 6 Per Arne Vollan 2020-02-27 14:41:11 PST 
Created attachment 391920 [details]
Patch
Comment 7 Per Arne Vollan 2020-02-27 14:45:57 PST 
Created attachment 391921 [details]
Patch
Comment 8 WebKit Commit Bot 2020-02-27 15:45:21 PST 
Comment on attachment 391921 [details]
Patch

Clearing flags on attachment: 391921

Committed r257595: <https://trac.webkit.org/changeset/257595>
Comment 9 WebKit Commit Bot 2020-02-27 15:45:23 PST 
All reviewed patches have been landed.  Closing bug.