| Summary: | [ews] commit queue should skip building and testing for rollout patches | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2020-02-27 10:40:36 PST
Created attachment 391890 [details]
Patch
Comment on attachment 391890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391890&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1584 > + incorrectLayoutLines = None Is this supposed to be part of this patch? (In reply to Jonathan Bedard from comment #3) > Is this supposed to be part of this patch? Yes, without this there is an exception because self.incorrectLayoutLines in not defined in getResultSummary(). (e.g.: https://ews-build.webkit-uat.org/#/builders/26/builds/924) File "steps.py", line 1809, in getResultSummary if self.results != SUCCESS and self.incorrectLayoutLines: File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py", line 295, in __getattr__ attr_name=name)) exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute 'incorrectLayoutLines' (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #3) > > Is this supposed to be part of this patch? > Yes, without this there is an exception because self.incorrectLayoutLines in > not defined in getResultSummary(). (e.g.: > https://ews-build.webkit-uat.org/#/builders/26/builds/924) > > File "steps.py", line 1809, in getResultSummary > if self.results != SUCCESS and self.incorrectLayoutLines: > File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py", > line 295, in __getattr__ > attr_name=name)) > exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute > 'incorrectLayoutLines' Is it supposed to be a class variable? Or should it be an instance variable? Created attachment 391912 [details]
Patch
(In reply to Jonathan Bedard from comment #5) > Is it supposed to be a class variable? Or should it be an instance variable? Updated patch uses instance variable. Created attachment 391975 [details]
Patch
Committed r257636: <https://trac.webkit.org/changeset/257636> |