Bug 208323

Summary: REGRESSION (r257391-257396): [ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order.html is failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, nham, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jacob Uphoff 2020-02-27 09:06:16 PST 
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order.html

This test is first seen to fail on r257396 and passed on r257390. 

This test is failing on release and debug for iOS 13.

History:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fbrowsing-the-web%2Fhistory-traversal%2Fscroll-restoration-order.html

Diff:

-FAIL Traversing history should restore scroll position after dispatching popstate and before dispatching hashchange assert_array_approx_equals: scroll is restored before hashchange for #2 property 0, expected 100 +/- 1, expected 100 but got 555
+FAIL Traversing history should restore scroll position after dispatching popstate and before dispatching hashchange assert_not_equals: scroll is restored before popstate for #2 got disallowed value 100
Comment 1 Radar WebKit Bug Importer 2020-02-27 09:06:37 PST 
<rdar://problem/59849043>
Comment 2 Jacob Uphoff 2020-02-27 09:16:53 PST 
https://trac.webkit.org/changeset/257394/webkit

This is the most likely commit to have caused the regression.
Comment 3 Ben Nham 2020-02-27 15:19:34 PST 
Created attachment 391926 [details]
Patch
Comment 4 Ryan Haddad 2020-02-27 17:01:55 PST 
Comment on attachment 391926 [details]
Patch

cq+'ing since the test passed on the iOS bot.
Comment 5 WebKit Commit Bot 2020-02-27 17:46:33 PST 
Comment on attachment 391926 [details]
Patch

Clearing flags on attachment: 391926

Committed r257608: <https://trac.webkit.org/changeset/257608>
Comment 6 WebKit Commit Bot 2020-02-27 17:46:35 PST 
All reviewed patches have been landed.  Closing bug.