Bug 208298

Summary: Load async scripts with low priority
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Antti Koivisto 2020-02-27 05:47:50 PST
They are assumed to be non-critical. This matches other browsers.
Comment 1 Antti Koivisto 2020-02-27 06:32:39 PST
Created attachment 391854 [details]
patch
Comment 2 Anders Carlsson 2020-02-27 07:02:38 PST
Comment on attachment 391854 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391854&action=review

> Source/WebCore/dom/LoadableClassicScript.cpp:134
> +        return { };

I'd return std::nullopt here, but that's just me.
Comment 3 WebKit Commit Bot 2020-02-27 08:02:14 PST
Comment on attachment 391854 [details]
patch

Clearing flags on attachment: 391854

Committed r257566: <https://trac.webkit.org/changeset/257566>
Comment 4 WebKit Commit Bot 2020-02-27 08:02:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-27 08:03:17 PST
<rdar://problem/59847342>