Bug 208295

Summary:

REGRESSION(r257299): [GTK] Test fast/replaced/table-percent-height.html is failing since r257299

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply

Priority:

Keywords:

Gtk, Regression

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

208296

Attachments:

Description	Flags
Patch	aperez: review+, aperez: commit-queue-

Description Carlos Garcia Campos 2020-02-27 03:34:11 PST

We are now hardcoding the size of check and radio buttons, except when width and height are both specified.

Comment 1 Carlos Garcia Campos 2020-02-27 03:35:54 PST

Created attachment 391847 [details]
Patch

Comment 2 Adrian Perez 2020-02-27 05:34:21 PST

Comment on attachment 391847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391847&action=review

Please fix the typo in the ChangeLog before landing =)

> Source/WebCore/ChangeLog:11
> +        (WebCore::ThemeAdwaita::controlSize const): Only set width and height of check and rario buttons when they are

Typo: s/rario/radio

Comment 3 Carlos Garcia Campos 2020-02-28 01:36:27 PST

Committed r257629: <https://trac.webkit.org/changeset/257629>