| Summary: | Remove initial layout throttle | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, jacob_uphoff, kangil.han, koivisto, nham, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 208536 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ben Nham
2020-02-26 21:27:14 PST
Created attachment 391837 [details]
Patch
Comment on attachment 391837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391837&action=review > Source/WebCore/page/SettingsBase.cpp:-67 > -// This amount of time must have elapsed before we will even consider scheduling a layout without a delay. > -// FIXME: For faster machines this value can really be lowered to 200. 250 is adequate, but a little high > -// for dual G5s. :) > -static const Seconds layoutScheduleThreshold = 250_ms; My dual G5s are going to fly! *** Bug 204031 has been marked as a duplicate of this bug. *** Created attachment 391966 [details]
Patch
Alan said he could take a look at the layout test issues here, so assigning to him. I already put in a couple workarounds for LayoutTests in the latest patch for ios-wk2: - tiled-drawing-async-frame-scrolling.html: the third iframe wasn't in the render tree, which was causing this to fail; worked around this by waiting for the entire window and all iframes to load before starting the test - autoscroll-in-iframe-body.html: I think this was issuing a click event in an iframe before the iframe had rendered There are also a couple of mac-wk2 layout tests that are failing now that are somewhat similar (they attempt to move/click the mouse after an onload event). As Alan said, we should probably remove the workarounds and make sure we fully understand the implications of removing the layout timer. LayoutTests/compositing/tiling/tiled-drawing-async-frame-scrolling.html is fixed at r257752 animations/cross-fade-list-style-image.html is fixed at r257764 Created attachment 392291 [details]
Patch
fast/images/animated-gif-no-layout.html is fixed at r257811 fast/events/autoscroll-in-iframe.html fails on trunk (run locally) Created attachment 392417 [details]
Patch
Created attachment 392418 [details]
Patch
Comment on attachment 392418 [details] Patch Clearing flags on attachment: 392418 Committed r257862: <https://trac.webkit.org/changeset/257862> All reviewed patches have been landed. Closing bug. The changes made here caused https://bugs.webkit.org/show_bug.cgi?id=208653 |