Bug 208281

Summary: [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208082
Attachments:
Description Flags
Patch
none
To Land none

Description Ryan Haddad 2020-02-26 17:27:52 PST 
The API test added with https://trac.webkit.org/changeset/257487/webkit is failing on iPad simulator bots with the following output:

    TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder
        
        /Volumes/Data/slave/ios-simulator-13-release/build/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:125
        Expected equality of these values:
          "BODY"
          [webView stringByEvaluatingJavaScript:@"document.activeElement.tagName"]
            Which is: "DIV"
        
Example of failure:
https://build.webkit.org/builders/Apple%20iPadOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/2271

Test history:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder
Comment 1 Radar WebKit Bug Importer 2020-02-26 17:30:58 PST 
<rdar://problem/59829265>
Comment 2 Daniel Bates 2020-02-26 18:32:56 PST 
Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss keyboard or fake a keyboard dismissal. Can we skip the test on iPad?
Comment 3 Ryan Haddad 2020-02-27 16:25:54 PST 
(In reply to Daniel Bates from comment #2)
> Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss
> keyboard or fake a keyboard dismissal. Can we skip the test on iPad?
Is there a platform check for iPad simulator that you could add to the test?
(I'm not sure if such a thing exists)
Comment 4 Daniel Bates 2020-05-03 14:58:55 PDT 
(In reply to Ryan Haddad from comment #3)
> (In reply to Daniel Bates from comment #2)
> > Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss
> > keyboard or fake a keyboard dismissal. Can we skip the test on iPad?
> Is there a platform check for iPad simulator that you could add to the test?
> (I'm not sure if such a thing exists)

So, not a way to skip a test, but there is a way to force an iPad to behave like an iPhone: IPhoneUserInterfaceSwizzler.
Comment 5 Daniel Bates 2020-05-03 15:08:37 PDT 
Created attachment 398335 [details]
Patch
Comment 6 Daniel Bates 2020-05-03 15:13:55 PDT 
Created attachment 398336 [details]
To Land
Comment 7 Daniel Bates 2020-05-03 15:14:49 PDT 
Comment on attachment 398336 [details]
To Land

Clearing flags on attachment: 398336

Committed r261068: <https://trac.webkit.org/changeset/261068>
Comment 8 Daniel Bates 2020-05-03 15:14:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Daniel Bates 2020-05-03 15:37:45 PDT 
Committed build fix <https://trac.webkit.org/changeset/261069>