Bug 208275

Summary:

Enhance JSObjectGetProperty() to mitigate against null object pointers.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	rmorisset: review+

Description Mark Lam 2020-02-26 16:16:52 PST

The client really shouldn't pass us a null JSObjectRef, but we'll be nice and mitigate it this time.

<rdar://problem/59789796>

Comment 1 Mark Lam 2020-02-26 16:17:44 PST

Oops ... wrong radar.  Need a new one.

Comment 2 Radar WebKit Bug Importer 2020-02-26 16:18:05 PST

<rdar://problem/59826325>

Comment 3 Mark Lam 2020-02-26 16:23:22 PST

Created attachment 391803 [details]
proposed patch.

Comment 4 Robin Morisset 2020-02-26 16:25:30 PST

Comment on attachment 391803 [details]
proposed patch.

r=me

Comment 5 Mark Lam 2020-02-26 16:30:05 PST

Thanks for the review.  Landed in r257529: <http://trac.webkit.org/r257529>.