Bug 208254

Summary: Clean up HitTestLocation.h
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208269
Bug Depends on:    
Bug Blocks: 208947    
Attachments:
Description Flags
Patch none

Description Daniel Bates 2020-02-26 11:55:25 PST 
Use C++11 and later features to reduce code duplication and simplify the code in HitTestLocation.h. This will make it easier for me to add a new rect-based location constructor in the future.
Comment 1 Radar WebKit Bug Importer 2020-02-26 11:55:37 PST 
<rdar://problem/59815136>
Comment 2 Daniel Bates 2020-02-26 12:01:35 PST 
Created attachment 391765 [details]
Patch
Comment 3 Daniel Bates 2020-02-26 12:05:10 PST 
Comment on attachment 391765 [details]
Patch

Clearing flags on attachment: 391765

Committed r257502: <https://trac.webkit.org/changeset/257502>
Comment 4 Daniel Bates 2020-02-26 12:05:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2020-03-11 14:44:57 PDT 
Comment on attachment 391765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391765&action=review

> Source/WebCore/rendering/HitTestLocation.cpp:-56
> -    , m_isRectBased(true)

This is wrong. This needs to be set to true.
Comment 6 Daniel Bates 2020-03-11 15:48:49 PDT 
(In reply to Daniel Bates from comment #5)
> Comment on attachment 391765 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391765&action=review
> 
> > Source/WebCore/rendering/HitTestLocation.cpp:-56
> > -    , m_isRectBased(true)
> 
> This is wrong. This needs to be set to true.

Fixed in bug #208947.