| Summary: | Clean up HitTestLocation.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, pdr, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208269 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 208947 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2020-02-26 11:55:25 PST
Created attachment 391765 [details]
Patch
Comment on attachment 391765 [details] Patch Clearing flags on attachment: 391765 Committed r257502: <https://trac.webkit.org/changeset/257502> All reviewed patches have been landed. Closing bug. Comment on attachment 391765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391765&action=review > Source/WebCore/rendering/HitTestLocation.cpp:-56 > - , m_isRectBased(true) This is wrong. This needs to be set to true. (In reply to Daniel Bates from comment #5) > Comment on attachment 391765 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391765&action=review > > > Source/WebCore/rendering/HitTestLocation.cpp:-56 > > - , m_isRectBased(true) > > This is wrong. This needs to be set to true. Fixed in bug #208947. |