Bug 208251

Summary: REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206911    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Jacob Uphoff 2020-02-26 11:07:33 PST 
inspector/network/client-blocked-load.html is failing after commit r257410 on all of Mac OS
Comment 1 Radar WebKit Bug Importer 2020-02-26 11:07:53 PST 
<rdar://problem/59812765>
Comment 3 Jacob Uphoff 2020-02-26 11:20:23 PST 
Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-actual.txt
@@ -4,6 +4,8 @@
 == Running test suite: ClientBlockedResourceLoad
 -- Running test case: TriggerBlockedResourceLoad
 PASS: Resource should be created.
-PASS: Request url should be rewritten to the null string.
+FAIL: Request url should be rewritten to the null string.
+    Expected: truthy
+    Actual: false
 PASS: Resource load should fail.
Comment 4 Devin Rousso 2020-02-26 11:30:25 PST 
Created attachment 391761 [details]
Patch
Comment 5 Timothy Hatcher 2020-02-26 12:09:55 PST 
Comment on attachment 391761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review

> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32
> +        this._url = url;

Could you use ?? Instead?
Comment 6 Devin Rousso 2020-02-26 12:27:29 PST 
Comment on attachment 391761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review

>> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32
>> +        this._url = url;
> 
> Could you use ?? Instead?

I could've, and initially I did just that :P

For the reason listed in the ChangeLog, I'd prefer to avoid introducing a potential other bug by changing functionality.  I think it's safer to just leave it as it was.
Comment 7 WebKit Commit Bot 2020-02-26 13:10:58 PST 
Comment on attachment 391761 [details]
Patch

Clearing flags on attachment: 391761

Committed r257504: <https://trac.webkit.org/changeset/257504>
Comment 8 WebKit Commit Bot 2020-02-26 13:11:00 PST 
All reviewed patches have been landed.  Closing bug.