| Summary: | [ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Lawrence <Lawrence.j> | ||||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, mmaxfield, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | iOS 13 | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208084 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jason Lawrence
2020-02-26 09:04:55 PST
I have marked this test as failing while the issue is investigated. https://trac.webkit.org/changeset/257476/webkit I am able to reproduce this issue with r257468 by running the command below. run-webkit-tests fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html --iterations 3000 --exit-after-n-failures 5 -f --force --ios-simulator [4/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [4/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [6/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [7/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [8/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) Exiting early after 5 failures. 6 tests run. 1 test ran as expected, 5 didn't (2994 didn't run): This is a brand new test added with https://bugs.webkit.org/show_bug.cgi?id=208084 We rolled out the change that introduced this test, so we should remove this test expectation entry and close the bug. I have removed the test expectations. https://trac.webkit.org/changeset/257516/webkit This test is failing again after it was re-landed in https://trac.webkit.org/changeset/257550 Marked test as flaky again in https://trac.webkit.org/changeset/257582/webkit According to that screenshot, the test is still passing, it is just being rendered with a viewport size that is unexpected. The solution is probably to turn this into a text test. Alright, I have a fix, testing it now. Created attachment 392001 [details]
Patch
Created attachment 392002 [details]
Patch
Comment on attachment 392002 [details] Patch Clearing flags on attachment: 392002 Committed r257651: <https://trac.webkit.org/changeset/257651> All reviewed patches have been landed. Closing bug. Removed flaky expectation in https://trac.webkit.org/changeset/257669/webkit |