Bug 208242

Summary:

GPUProcess should be made aware of device orientation for correct video capture frame rotation computation

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, simon.fraser, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2020-02-26 07:13:54 PST

GPUProcess should be made aware of device orientation for correct video capture frame rotation computation

Comment 1 youenn fablet 2020-02-26 07:24:44 PST

Created attachment 391746 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2020-02-26 07:25:10 PST

<rdar://problem/59804921>

Comment 3 WebKit Commit Bot 2020-02-26 09:15:52 PST

Comment on attachment 391746 [details]
Patch

Clearing flags on attachment: 391746

Committed r257478: <https://trac.webkit.org/changeset/257478>

Comment 4 WebKit Commit Bot 2020-02-26 09:15:53 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Simon Fraser (smfr) 2020-02-26 09:42:25 PST

Comment on attachment 391746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391746&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:78
> +    void setOrientationForMediaCapture(uint64_t orientation);

Why does orientation need 64 bits instead of 2?