Bug 208240

Summary: Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jacob_uphoff, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2020-02-26 05:41:13 PST
Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
Comment 1 youenn fablet 2020-02-26 05:47:02 PST
Created attachment 391743 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-26 07:29:41 PST
Comment on attachment 391743 [details]
Patch

Clearing flags on attachment: 391743

Committed r257470: <https://trac.webkit.org/changeset/257470>
Comment 3 WebKit Commit Bot 2020-02-26 07:29:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-26 07:30:19 PST
<rdar://problem/59805022>
Comment 5 Jacob Uphoff 2020-02-26 09:53:10 PST
Reverted r257470 for reason:

This broke the build for tvOS and watchOS

Committed r257479: <https://trac.webkit.org/changeset/257479>
Comment 6 youenn fablet 2020-02-27 18:59:53 PST
Created attachment 391955 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2020-02-27 19:08:41 PST
Comment on attachment 391955 [details]
Patch for landing

Rejecting attachment 391955 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 391955, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13330263
Comment 8 youenn fablet 2020-02-28 00:57:29 PST
Created attachment 391969 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2020-02-28 03:28:41 PST
Comment on attachment 391969 [details]
Patch for landing

Clearing flags on attachment: 391969

Committed r257633: <https://trac.webkit.org/changeset/257633>
Comment 10 WebKit Commit Bot 2020-02-28 03:28:43 PST
All reviewed patches have been landed.  Closing bug.